Fix multiline sorting with force-alphabetical-sort #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised in issue 364. The separate code for --force-alphabetical-sort has been removed and a boolean flag added to handle sorting with or without case in the _module_key function (which handles the sorting). Note this commit alters these 2 tests: test_alphabetic_sorting_no_newlines, test_alphabetic_sorting This results in the lone imports being moved to the top of the file. I think this is better as it means the force_alphabetical_sort tests now behave similarly to the other tests in the file.
|
Awesome work! Great job reducing the line count while improving the functionality. Thanks! ~Timothy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in #364
The separate code for --force-alphabetical-sort has been removed and
a boolean flag added to handle sorting with or without case in the
_module_key function (which handles the sorting).
Note this commit alters these 2 tests:
test_alphabetic_sorting_no_newlines, test_alphabetic_sorting
This results in the lone imports being moved to the top of the file.
I think this is better as it means the force_alphabetical_sort tests
now behave similarly to the other tests in the file.
Please advise if it is ok to change the tests like this.
The big red commit in isort.py is because lines 444 -> 468 were removed and the
if statement was removed